RE: This counter "ip6InNoRoutes" does not follow the RFC4293 specification implementation

[Pudak, Filip]

Hi David,

It was indeed a bug. We've retested with '||' and the counter is incremented properly.

How do we go about including this change to the kernel? Will you perform the update?

Thanks,
Filip Pudak

-----Original Message-----
From: David Ahern <dsahern@xxxxxxxxxx> 
Sent: Thursday, 31 March 2022 16:13
To: Pudak, Filip <Filip.Pudak@xxxxxxxxxxxxx>; Xiao, Jiguang <Jiguang.Xiao@xxxxxxxxxxxxx>; davem@xxxxxxxxxxxxx; yoshfuji@xxxxxxxxxxxxxx; kuba@xxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
Subject: Re: This counter "ip6InNoRoutes" does not follow the RFC4293 specification implementation

On 3/31/22 3:13 AM, Pudak, Filip wrote:
> Hi David,
> 
> So we end up in ip6_pkt_discard -> ip6_pkt_drop :
> 
> ---
> if (netif_is_l3_master(skb->dev) &&
> 	    dst->dev == net->loopback_dev)

That's a bug. I can not think of a case where those 2 conditions will ever be true at the same time. I think that should '||'


> 		idev = __in6_dev_get_safely(dev_get_by_index_rcu(net, IP6CB(skb)->iif));
> 	else
> 		idev = ip6_dst_idev(dst);
> 
> 	switch (ipstats_mib_noroutes) {
> 	case IPSTATS_MIB_INNOROUTES:
> 		type = ipv6_addr_type(&ipv6_hdr(skb)->daddr);
> 		if (type == IPV6_ADDR_ANY) {
> 			IP6_INC_STATS(net, idev, IPSTATS_MIB_INADDRERRORS);
> 			break;
> 		}
> 		fallthrough;
> 	case IPSTATS_MIB_OUTNOROUTES:
> 		IP6_INC_STATS(net, idev, ipstats_mib_noroutes);
> 		break;
> 	}
> 
> ---
> What happens in the case where the l3mdev is not used, is that we go into the else branch(idev = ip6_dst_idev(dst);) and then we can see that the counter is incremented on the loopback IF.
> 
> So is the only option that l3mdev should be used or is it strange to expect that the idev where the INNOROUTES should increment is the ingress device by default in this case?
>