Re: [PATCH] mtd: rawnand: fix ecc parameters for mt7622

[Miquel Raynal]

On Sat, 2022-04-02 at 16:03:13 UTC, Chuanhong Guo wrote:
> According to the datasheet, mt7622 only has 5 ECC capabilities instead
> of 7, and the decoding error register is arranged  as follows:
> +------+---------+---------+---------+---------+
> | Bits |  19:15  |  14:10  |   9:5   |   4:0   |
> +------+---------+---------+---------+---------+
> | Name | ERRNUM3 | ERRNUM2 | ERRNUM1 | ERRNUM0 |
> +------+---------+---------+---------+---------+
> This means err_mask should be 0x1f instead of 0x3f and the number of
> bits shifted in mtk_ecc_get_stats should be 5 instead of 8.
> 
> This commit introduces err_shift for the difference in this register
> and fix other existing parameters.
> 
> Public MT7622 reference manual can be found on [0] and the info this
> commit is based on is from page 656 and page 660.
> 
> [0]: https://wiki.banana-pi.org/Banana_Pi_BPI-R64#Documents
> 
> Fixes: 98dea8d71931 ("mtd: nand: mtk: Support MT7622 NAND flash controller.")
> Signed-off-by: Chuanhong Guo <gch981213@xxxxxxxxx>

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/fixes, thanks.

Miquel