Re: [PATCH] staging: r8188eu: Remove goto to no-op exit label

From: Dan Carpenter
Date: Mon Apr 04 2022 - 06:00:28 EST


On Fri, Apr 01, 2022 at 01:41:40PM -0700, Ira Weiny wrote:
> On Fri, Apr 01, 2022 at 08:35:13PM +0200, Fabio M. De Francesco wrote:
> > In function rtw_free_netdev() there are two "goto" jumps to a no-op exit
> > label called "RETURN". Remove the label and return in line.
>
> Thanks for the patch! However, A good commit message lists the why and what of
> a change. I don't see a why for this commit?

People, stop belly aching about commit messages.

"Delete no-op goto" is sufficient justification.

regards,
dan carpenter