Re: [PATCH] HID: multitouch: add quirks to enable Lenovo X12 trackpoint

From: Benjamin Tissoires
Date: Mon Apr 04 2022 - 06:09:55 EST


Hi,

On Sun, Apr 3, 2022 at 6:58 PM Tao Jin <tao-j@xxxxxxxxxxx> wrote:
>
> This applies the similar quirks used by previous generation devices
> such as X1 tablet for X12 tablet, so that the trackpoint and buttons
> can work.
>
> This patch was applied and tested working on 5.17.1 .
>
> Signed-off-by: Tao Jin <tao-j@xxxxxxxxxxx>

Thanks a lot for the patch.

I have added the CC: stable@xxxxxxxxxxxxxxx tag and pushed the patch
to for-5.18/upstream-fixes

Cheers,
Benjamin

> ---
> drivers/hid/hid-ids.h | 1 +
> drivers/hid/hid-multitouch.c | 6 ++++++
> 2 files changed, 7 insertions(+)
>
> diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
> index 78bd3dd..aca7909 100644
> --- a/drivers/hid/hid-ids.h
> +++ b/drivers/hid/hid-ids.h
> @@ -760,6 +760,7 @@
> #define USB_DEVICE_ID_LENOVO_X1_COVER 0x6085
> #define USB_DEVICE_ID_LENOVO_X1_TAB 0x60a3
> #define USB_DEVICE_ID_LENOVO_X1_TAB3 0x60b5
> +#define USB_DEVICE_ID_LENOVO_X12_TAB 0x60fe
> #define USB_DEVICE_ID_LENOVO_OPTICAL_USB_MOUSE_600E 0x600e
> #define USB_DEVICE_ID_LENOVO_PIXART_USB_MOUSE_608D 0x608d
> #define USB_DEVICE_ID_LENOVO_PIXART_USB_MOUSE_6019 0x6019
> diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
> index 99eabfb..0dece60 100644
> --- a/drivers/hid/hid-multitouch.c
> +++ b/drivers/hid/hid-multitouch.c
> @@ -2034,6 +2034,12 @@ static const struct hid_device_id mt_devices[] = {
> USB_VENDOR_ID_LENOVO,
> USB_DEVICE_ID_LENOVO_X1_TAB3) },
>
> + /* Lenovo X12 TAB Gen 1 */
> + { .driver_data = MT_CLS_WIN_8_FORCE_MULTI_INPUT,
> + HID_DEVICE(BUS_USB, HID_GROUP_MULTITOUCH_WIN_8,
> + USB_VENDOR_ID_LENOVO,
> + USB_DEVICE_ID_LENOVO_X12_TAB) },
> +
> /* MosArt panels */
> { .driver_data = MT_CLS_CONFIDENCE_MINUS_ONE,
> MT_USB_DEVICE(USB_VENDOR_ID_ASUS,
> --
> 2.35.1
>