Re: [PATCH] amd64-agp: remove redundant assignment to variable i

[Nick Desaulniers]

On Thu, Mar 17, 2022 at 5:01 PM Colin Ian King <colin.i.king@xxxxxxxxx> wrote:
>
> Variable i is being assigned a value that is never read, it is being
> re-assigned later in a for-loop. The assignment is redundant and can
> be removed.
>
> Cleans up clang scan build warning:
> drivers/char/agp/amd64-agp.c:336:2: warning: Value stored to 'i' is
> never read [deadcode.DeadStores]
>
> Signed-off-by: Colin Ian King <colin.i.king@xxxxxxxxx>

Thanks for the patch!
Reviewed-by: Nick Desaulniers <ndesaulniers@xxxxxxxxxx>

> ---
>  drivers/char/agp/amd64-agp.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/char/agp/amd64-agp.c b/drivers/char/agp/amd64-agp.c
> index dc78a4fb879e..5f64991c73bf 100644
> --- a/drivers/char/agp/amd64-agp.c
> +++ b/drivers/char/agp/amd64-agp.c
> @@ -333,7 +333,6 @@ static int cache_nbs(struct pci_dev *pdev, u32 cap_ptr)
>         if (!amd_nb_has_feature(AMD_NB_GART))
>                 return -ENODEV;
>
> -       i = 0;
>         for (i = 0; i < amd_nb_num(); i++) {
>                 struct pci_dev *dev = node_to_amd_nb(i)->misc;
>                 if (fix_northbridge(dev, pdev, cap_ptr) < 0) {
> --
> 2.35.1
>
>


-- 
Thanks,
~Nick Desaulniers