Re: [PATCH v2] usb: gadget: uvc: allow changing interface name via configfs
From: Dan Vacura
Date: Mon Apr 04 2022 - 17:39:06 EST
On Sun, Apr 03, 2022 at 01:13:02PM +0700, Bagas Sanjaya wrote:
> On 01/04/22 23.04, Dan Vacura wrote:
> > Add a configfs entry, "function_name", to change the iInterface field
> > for VideoControl. This name is used on host devices for user selection,
> > useful when multiple cameras are present. The default will remain "UVC
> > Camera".
> >
> > Signed-off-by: Dan Vacura <w36195@xxxxxxxxxxxx>
> > ---
> > Changes in v2:
> > - remove stable cc
> >
> > .../ABI/testing/configfs-usb-gadget-uvc | 1 +
> > Documentation/usb/gadget-testing.rst | 1 +
> > drivers/usb/gadget/function/f_uvc.c | 4 +-
> > drivers/usb/gadget/function/u_uvc.h | 1 +
> > drivers/usb/gadget/function/uvc_configfs.c | 41 +++++++++++++++++++
> > 5 files changed, 47 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/ABI/testing/configfs-usb-gadget-uvc b/Documentation/ABI/testing/configfs-usb-gadget-uvc
> > index 889ed45be4ca..611b23e6488d 100644
> > --- a/Documentation/ABI/testing/configfs-usb-gadget-uvc
> > +++ b/Documentation/ABI/testing/configfs-usb-gadget-uvc
> > @@ -7,6 +7,7 @@ Description: UVC function directory
> > streaming_maxburst 0..15 (ss only)
> > streaming_maxpacket 1..1023 (fs), 1..3072 (hs/ss)
> > streaming_interval 1..16
> > + function_name string [32]
> > =================== =============================
>
> Since you mention that default function_name is "UVC Camera", why don't you
> mention it in the documentation?
Good question. The rest of the file didn't contain any default values
and I wasn't sure what the process is for keeping things like this in
sync between source and documentation. Looking through most of the other
usb function files I don't see any mention of the hardcoded default
values either, so maybe it's intentional to not include.
>
> --
> An old man doll... just what I always wanted! - Clara