Re: [PATCH 2/3] staging: rtl8712: add two validation check in r8712_init_drv_sw()

Date: Mon Apr 04 2022 - 22:38:51 EST

On Monday, April 4, 2022 10:30 PM +0800, gregkh@xxxxxxxxxxxxxxxxxxx wrote:
> You just leaked memory :(
> please please please test these types of "fix up error handling"
> changes, as there are lots and lots of ways to get these wrong.

It seems that you missed the third email in this series.

In fact, I did not ignore the memory leak problem. But considering that there are other paths which can also lead to memory leak, I separated another patch to deal with them specifically.

In the next version, I will adjust the sequence of the patches and add some descriptions to explicitly show the relations.

Xiaoke Wang