Re: [PATCH v5 3/3] arm64: dts: qcom: sc7280: Add dt nodes for sound card

[Srinivasa Rao Mandadapu]

On 3/22/2022 1:24 AM, Stephen Boyd wrote:
Thanks for your time Stephen!!
> Quoting Srinivasa Rao Mandadapu (2022-03-21 05:28:16)
> > diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
> > index ca799c2..369c1e9 100644
> > --- a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
> > @@ -84,6 +84,99 @@
> >                  pinctrl-names = "default";
> >                  pinctrl-0 = <&nvme_pwren>;
> >          };
> > +
> > +       sound: sound-card {
> How about
>
> 	sound: sound {
>
> It's not an actual sound card that you can plug in right?
Yes, it's not plug in sound-card. will change accordingly.
> > +               compatible = "google,sc7280-herobrine";
> > +               model = "sc7280-wcd938x-max98360a-1mic";
> > +               status = "okay";
> This status can be left out as it's the default.
Okay. will change accordingly.