Re: [PATCH] tee: optee: add missing mutext_destroy in optee_ffa_probe

[Jens Wiklander]

On Fri, Apr 1, 2022 at 4:00 AM Dongliang Mu <mudongliangabcd@xxxxxxxxx> wrote:
>
> On Thu, Mar 24, 2022 at 5:33 PM Dongliang Mu <mudongliangabcd@xxxxxxxxx> wrote:
> >
> > On Thu, Mar 24, 2022 at 4:29 PM Jens Wiklander
> > <jens.wiklander@xxxxxxxxxx> wrote:
> > >
> > > On Wed, Mar 16, 2022 at 2:51 PM Dongliang Mu <dzm91@xxxxxxxxxxx> wrote:
> > > >
> > > > From: Dongliang Mu <mudongliangabcd@xxxxxxxxx>
> > > >
> > > > The error handling code of optee_ffa_probe misses the mutex_destroy of
> > > > ffa.mutex when mutext_init succeeds.
> > > >
> > > > Fix this by adding mutex_destory of ffa.mutex at the error handling part
> > > >
> > > > Fixes: aceeafefff73 ("optee: use driver internal tee_context for some rpc")
> > >
> > > I believe this should be
> > > Fixes: 4615e5a34b95 ("optee: add FF-A support")
> > > don't you agree?
> >
> > Hi Jen,
> >
> > This commit 4615e5a34b95 is more suitable since mutex_init is introduced here.
> >
> > Why did I label the commit aceeafefff73?
> >
> > Because this commit tried to fix the issue, but only added one
> > mutex_destroy for &optee->call_queue.mutex, misses &optee->ffa.mutex.
> >
>
> ping?

I'm picking up this.

Thanks,
Jens