Re: [PATCH v2] soc: soc-dapm: fix two incorrect uses of list iterator

From: Mark Brown
Date: Tue Apr 05 2022 - 11:22:27 EST


On Tue, 29 Mar 2022 09:21:34 +0800, Xiaomeng Tong wrote:
> These two bug are here:
> list_for_each_entry_safe_continue(w, n, list,
> power_list);
> list_for_each_entry_safe_continue(w, n, list,
> power_list);
>
> After the list_for_each_entry_safe_continue() exits, the list iterator
> will always be a bogus pointer which point to an invalid struct objdect
> containing HEAD member. The funciton poniter 'w->event' will be a
> invalid value which can lead to a control-flow hijack if the 'w' can be
> controlled.
>
> [...]

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] soc: soc-dapm: fix two incorrect uses of list iterator
commit: f730a46b931d894816af34a0ff8e4ad51565b39f

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark