Re: [PATCH] x86/efi: Remove references of EFI earlyprintk from documentation
From: Ard Biesheuvel
Date: Tue Apr 05 2022 - 17:15:44 EST
On Tue, 5 Apr 2022 at 18:26, Jonathan Corbet <corbet@xxxxxxx> wrote:
> Akihiko Odaki <akihiko.odaki@xxxxxxxxx> writes:
> > x86 EFI earlyprink was removed with commit 69c1f396f25b ("efi/x86:
> > Convert x86 EFI earlyprintk into generic earlycon implementation").
> So I will confess that I don't know this area well enough to know
> whether this patch makes sense or not. To help with that, it would have
> been good to CC Ard, who is the author of the patch you cite above.
> Adding him now.
> Ard, do you agree with this change (preserved below)?
Yes, it looks fine to me.
Reviewed-by: Ard Biesheuvel <ardb@xxxxxxxxxx>
> > Signed-off-by: Akihiko Odaki <akihiko.odaki@xxxxxxxxx>
> > ---
> > Documentation/admin-guide/kernel-parameters.txt | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> > diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
> > index f5a27f067db9..fb39337f4123 100644
> > --- a/Documentation/admin-guide/kernel-parameters.txt
> > +++ b/Documentation/admin-guide/kernel-parameters.txt
> > @@ -1252,7 +1252,7 @@
> > Append ",keep" to not disable it when the real console
> > takes over.
> > - Only one of vga, efi, serial, or usb debug port can
> > + Only one of vga, serial, or usb debug port can
> > be used at a time.
> > Currently only ttyS0 and ttyS1 may be specified by
> > @@ -1267,7 +1267,7 @@
> > Interaction with the standard serial driver is not
> > very good.
> > - The VGA and EFI output is eventually overwritten by
> > + The VGA output is eventually overwritten by
> > the real console.
> > The xen option can only be used in Xen domains.
> > --
> > 2.35.1