Re: [PATCH mlx5-next 4/5] net/mlx5: Remove tls vs. ktls separation as it is the same

[Leon Romanovsky]

On Tue, Apr 05, 2022 at 10:20:49AM -0700, Saeed Mahameed wrote:
> On 05 Apr 08:43, Leon Romanovsky wrote:
> > On Mon, Apr 04, 2022 at 05:33:22PM -0700, Saeed Mahameed wrote:
> > > On 04 Apr 15:08, Leon Romanovsky wrote:
> > > > From: Leon Romanovsky <leonro@xxxxxxxxxx>
> > > >
> > > > After removal FPGA TLS, we can remove tls->ktls indirection too,
> > > > as it is the same thing.
> 
> [...]
> 
> > > rename drivers/net/ethernet/mellanox/mlx5/core/en_accel/{tls_stats.c => ktls_stats.c} (76%)
> > > 
> > > Why not ktls_*.c => tls_*.c ?
> > 
> > Mostly because other drivers use _ktls_ name for this type of functionality.
> > Plus internally, Tariq suggested to squash everything into ktls.
> > 
> > > 
> > > Since we now have one TLS implementation, it would've been easier to maybe
> > > repurpose TLS to be KTLS only and avoid renaming every TLS to KTLS in all
> > > functions and files.
> > > 
> > > So just keep tls.c and all mlx5_tls_xyz functions and implement ktls
> > > directly in them, the renaming will be done only on the ktls implementation
> > > part of the code rather than in every caller.
> > 
> > Should I do it or keep this patch as is?
> > 
> 
> Keep it, i don't have any strong feeling about this,
> I just wanted to reduce the patch size.

Thanks for the review.