Re: [PATCH trivial] perf vendor events intel: Assorted style fixes

From: Geert Uytterhoeven
Date: Tue Apr 05 2022 - 19:53:33 EST


On Mon, Jun 17, 2019 at 6:10 PM Liang, Kan <kan.liang@xxxxxxxxxxxxxxx> wrote:
> On 6/17/2019 11:56 AM, Arnaldo Carvalho de Melo wrote:
> > Em Mon, Jun 17, 2019 at 04:21:56PM +0200, Geert Uytterhoeven escreveu:
> >> - Do not use apostrophes for plurals,
> >> - Insert commas before "and",
> >> - Spelling s/statisfied/satisfied/.
> >
> > I think these files are generated from some other material from Intel,
> > i.e. if they update something somewhere else and regenerate those files,
> > your changes would be lost, right Andi, Kan? (Adding them to the CC list).
> >
>
> Yes, they are generated from JSON files in
> https://download.01.org/perfmon/
>
> I will forward the patch to our internal team to check the issues in
> JSON file.

The auto-generated files have been updated, the issues still exist.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds