Re: [PATCH v2 3/6] staging: vt6655: Rename macro arguments with CamelCase

[Greg Kroah-Hartman]

On Mon, Apr 04, 2022 at 10:48:47PM +0200, Philipp Hortmann wrote:
> Rename macro arguments with CamelCase in upc.h as
> they are not accepted by checkpatch.pl
> Removed datatype in macro arguments.
> 
> Since there are more than one checkpatch issue per line,
> more steps are rquired to fix.
> 
> Signed-off-by: Philipp Hortmann <philipp.g.hortmann@xxxxxxxxx>
> ---
> V1 -> V2: This patch was 4/7 and is now 3/6
> ---
>  drivers/staging/vt6655/upc.h | 36 ++++++++++++++++++------------------
>  1 file changed, 18 insertions(+), 18 deletions(-)
> 
> diff --git a/drivers/staging/vt6655/upc.h b/drivers/staging/vt6655/upc.h
> index b374db5fca81..f080a25e6cdf 100644
> --- a/drivers/staging/vt6655/upc.h
> +++ b/drivers/staging/vt6655/upc.h
> @@ -20,34 +20,34 @@
>  
>  /* For memory mapped IO */
>  
> -#define VNSvInPortB(dwIOAddress, pbyData) \
> -	(*(pbyData) = ioread8(dwIOAddress))
> +#define VNSvInPortB(io_address, data) \
> +	(*(data) = ioread8(io_address))

These should all just go away, don't spend time cleaning them up.

Replace the callers with the ioread* calls instead.  Should be one patch
per macro to remove.

thanks,

greg k-h