Re: [PATCH 2/3] staging: r8188eu: drop redundant if check in check_fwstate

From: Greg Kroah-Hartman
Date: Tue Apr 05 2022 - 21:54:06 EST

On Tue, Apr 05, 2022 at 06:12:39PM +0530, Vihas Makwana wrote:
> The if check is redundant. Drop it and simplify the funciton.
> Also, drop clr_fwstate(), clr_fwstate_ex(), up_scanned_network() and
> down_scanned_network() as they are not used anywhere.

When you write "also" in a changelog text, that's a huge hint that you
should break this up into multiple patches.

Remember, do only one logical thing per change. This should be split up
into 2 patches.


greg k-h