Re: [PATCH 0/4] usb: phy: generic: Support enabling/disabling VBUS
From: Sean Anderson
Date: Tue Apr 05 2022 - 21:56:50 EST
On 4/5/22 11:02 AM, Greg Kroah-Hartman wrote:
> On Tue, Apr 05, 2022 at 10:51:34AM -0400, Sean Anderson wrote:
>> On 1/14/22 12:09 PM, Sean Anderson wrote:
>> > The generic USB phy has had VBUS-related code for a long time, but it
>> > has always been broken, since the regulator was never gotten from the
>> > device tree. However, the support itself seems not very useful, since
>> > e.g. usb_phy_vbus_on/off has no users and usb_phy_set_power is only
>> > used by gadgets to make sure they don't draw too much current. Instead,
>> > use the VBUS regulator to implement otg_set_vbus, which is called from
>> > several drivers. This results in a change in semantics of VBUS, but
>> > since support was always broken I don't think this will have any affect.
>> > Sean Anderson (4):
>> > dt-bindings: usb: usb-nop-xceiv: Repurpose vbus-regulator
>> > usb: phy: generic: Get the vbus supply
>> > usb: phy: generic: Implement otg->set_vbus
>> > usb: phy: generic: Disable vbus on removal
>> > .../bindings/usb/usb-nop-xceiv.yaml | 8 +--
>> > drivers/usb/phy/phy-generic.c | 55 +++++++++----------
>> > 2 files changed, 31 insertions(+), 32 deletions(-)
>> When this was submitted I got an email saying that the merge window was
>> closed... but I think it has opened and closed again during the
>> intervening time.
> It opened yesterday. Please give us a chance to catch up.
Ah, sorry. I thought this series had just gotten lost.
> While that happens, please take the time to review other changes on the
> mailing lists, we can always use the help.