Re: [PATCH 08/11] mt76: Fix undefined behavior due to shift overflowing the constant
From: Kalle Valo
Date: Wed Apr 06 2022 - 04:01:15 EST
Borislav Petkov <bp@xxxxxxxxx> writes:
> From: Borislav Petkov <bp@xxxxxxx>
> drivers/net/wireless/mediatek/mt76/mt76x2/pci.c: In function ‘mt76x2e_probe’:
> ././include/linux/compiler_types.h:352:38: error: call to ‘__compiletime_assert_946’ \
> declared with attribute error: FIELD_PREP: mask is not constant
> _compiletime_assert(condition, msg, __compiletime_assert_, __COUNTER__)
> See https://lore.kernel.org/r/YkwQ6%2BtIH8GQpuct@xxxxxxx for the gory
> details as to why it triggers with older gccs only.
> Signed-off-by: Borislav Petkov <bp@xxxxxxx>
As this fixes a compiler warning in Linus' tree, I would like to take
this to wireless tree and I assigned this to myself in patchwork.