Re: [PATCH v10 1/4] dt-bindings: display: mediatek: revise enum to const

From: CK Hu
Date: Wed Apr 06 2022 - 04:37:49 EST


Hi, Rex:

On Wed, 2022-04-06 at 11:00 +0800, Rex-BC Chen wrote:
> There won't be more than 1 fallback for these bindings, so we modify
> them to use const instead of enum.

Reviewed-by: CK Hu <ck.hu@xxxxxxxxxxxx>

>
> Signed-off-by: Rex-BC Chen <rex-bc.chen@xxxxxxxxxxxx>
> Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
> Reviewed-by: AngeloGioacchino Del Regno <
> angelogioacchino.delregno@xxxxxxxxxxxxx>
> ---
> .../devicetree/bindings/display/mediatek/mediatek,aal.yaml | 3 +--
> .../bindings/display/mediatek/mediatek,ccorr.yaml | 3 +--
> .../bindings/display/mediatek/mediatek,color.yaml | 6 ++
> ----
> .../bindings/display/mediatek/mediatek,dither.yaml | 3 +--
> .../bindings/display/mediatek/mediatek,gamma.yaml | 3 +--
> .../devicetree/bindings/display/mediatek/mediatek,ovl.yaml | 6 ++
> ----
> .../devicetree/bindings/display/mediatek/mediatek,rdma.yaml | 6 ++
> ----
> 7 files changed, 10 insertions(+), 20 deletions(-)
>
> diff --git
> a/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.yam
> l
> b/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.yam
> l
> index 61f0ed1e388f..cdb6d0819cca 100644
> ---
> a/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.yam
> l
> +++
> b/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.yam
> l
> @@ -29,8 +29,7 @@ properties:
> - mediatek,mt8183-disp-aal
> - mediatek,mt8192-disp-aal
> - mediatek,mt8195-disp-aal
> - - enum:
> - - mediatek,mt8173-disp-aal
> + - const: mediatek,mt8173-disp-aal
>
> reg:
> maxItems: 1
> diff --git
> a/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.y
> aml
> b/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.y
> aml
> index 0ed53b6238f0..7766c806c102 100644
> ---
> a/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.y
> aml
> +++
> b/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr.y
> aml
> @@ -28,8 +28,7 @@ properties:
> - items:
> - enum:
> - mediatek,mt8195-disp-ccorr
> - - enum:
> - - mediatek,mt8192-disp-ccorr
> + - const: mediatek,mt8192-disp-ccorr
>
> reg:
> maxItems: 1
> diff --git
> a/Documentation/devicetree/bindings/display/mediatek/mediatek,color.y
> aml
> b/Documentation/devicetree/bindings/display/mediatek/mediatek,color.y
> aml
> index 3ad842eb5668..0c9095b0411e 100644
> ---
> a/Documentation/devicetree/bindings/display/mediatek/mediatek,color.y
> aml
> +++
> b/Documentation/devicetree/bindings/display/mediatek/mediatek,color.y
> aml
> @@ -32,15 +32,13 @@ properties:
> - enum:
> - mediatek,mt7623-disp-color
> - mediatek,mt2712-disp-color
> - - enum:
> - - mediatek,mt2701-disp-color
> + - const: mediatek,mt2701-disp-color
> - items:
> - enum:
> - mediatek,mt8183-disp-color
> - mediatek,mt8192-disp-color
> - mediatek,mt8195-disp-color
> - - enum:
> - - mediatek,mt8173-disp-color
> + - const: mediatek,mt8173-disp-color
> reg:
> maxItems: 1
>
> diff --git
> a/Documentation/devicetree/bindings/display/mediatek/mediatek,dither.
> yaml
> b/Documentation/devicetree/bindings/display/mediatek/mediatek,dither.
> yaml
> index 6657549af165..8180ed0a89ff 100644
> ---
> a/Documentation/devicetree/bindings/display/mediatek/mediatek,dither.
> yaml
> +++
> b/Documentation/devicetree/bindings/display/mediatek/mediatek,dither.
> yaml
> @@ -28,8 +28,7 @@ properties:
> - enum:
> - mediatek,mt8192-disp-dither
> - mediatek,mt8195-disp-dither
> - - enum:
> - - mediatek,mt8183-disp-dither
> + - const: mediatek,mt8183-disp-dither
>
> reg:
> maxItems: 1
> diff --git
> a/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.y
> aml
> b/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.y
> aml
> index 78442339314f..5f1825b4512b 100644
> ---
> a/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.y
> aml
> +++
> b/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma.y
> aml
> @@ -29,8 +29,7 @@ properties:
> - enum:
> - mediatek,mt8192-disp-gamma
> - mediatek,mt8195-disp-gamma
> - - enum:
> - - mediatek,mt8183-disp-gamma
> + - const: mediatek,mt8183-disp-gamma
>
> reg:
> maxItems: 1
> diff --git
> a/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.yam
> l
> b/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.yam
> l
> index f77094e61443..51f8235f1b1b 100644
> ---
> a/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.yam
> l
> +++
> b/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.yam
> l
> @@ -33,13 +33,11 @@ properties:
> - enum:
> - mediatek,mt7623-disp-ovl
> - mediatek,mt2712-disp-ovl
> - - enum:
> - - mediatek,mt2701-disp-ovl
> + - const: mediatek,mt2701-disp-ovl
> - items:
> - enum:
> - mediatek,mt8195-disp-ovl
> - - enum:
> - - mediatek,mt8183-disp-ovl
> + - const: mediatek,mt8183-disp-ovl
>
> reg:
> maxItems: 1
> diff --git
> a/Documentation/devicetree/bindings/display/mediatek/mediatek,rdma.ya
> ml
> b/Documentation/devicetree/bindings/display/mediatek/mediatek,rdma.ya
> ml
> index e8c72afa0630..9a6756f185ee 100644
> ---
> a/Documentation/devicetree/bindings/display/mediatek/mediatek,rdma.ya
> ml
> +++
> b/Documentation/devicetree/bindings/display/mediatek/mediatek,rdma.ya
> ml
> @@ -35,13 +35,11 @@ properties:
> - enum:
> - mediatek,mt7623-disp-rdma
> - mediatek,mt2712-disp-rdma
> - - enum:
> - - mediatek,mt2701-disp-rdma
> + - const: mediatek,mt2701-disp-rdma
> - items:
> - enum:
> - mediatek,mt8192-disp-rdma
> - - enum:
> - - mediatek,mt8183-disp-rdma
> + - const: mediatek,mt8183-disp-rdma
>
> reg:
> maxItems: 1