[krzk-github:n/qcom-ufs-opp-v2 13/15] drivers/opp/core.c:2252:34: error: 'np' undeclared; did you mean 'up'?
From: kernel test robot
Date: Wed Apr 06 2022 - 06:28:19 EST
tree: https://github.com/krzk/linux n/qcom-ufs-opp-v2
head: fff8a3e9335a828deb502bbcf983c4316d27c74e
commit: 92622915a3dd2035b67cef4ef60bea1f941b3876 [13/15] PM wip
config: x86_64-randconfig-a013 (https://download.01.org/0day-ci/archive/20220406/202204061419.k57I1cIf-lkp@xxxxxxxxx/config)
compiler: gcc-11 (Debian 11.2.0-19) 11.2.0
reproduce (this is a W=1 build):
# https://github.com/krzk/linux/commit/92622915a3dd2035b67cef4ef60bea1f941b3876
git remote add krzk-github https://github.com/krzk/linux
git fetch --no-tags krzk-github n/qcom-ufs-opp-v2
git checkout 92622915a3dd2035b67cef4ef60bea1f941b3876
# save the config file to linux build tree
mkdir build_dir
make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>
All errors (new ones prefixed by >>):
drivers/opp/core.c: In function 'dev_pm_opp_set_clkname':
drivers/opp/core.c:2185:16: error: implicit declaration of function 'dev_pm_opp_set_clknames'; did you mean 'dev_pm_opp_set_clkname'? [-Werror=implicit-function-declaration]
2185 | return dev_pm_opp_set_clknames(dev, &name, 1);
| ^~~~~~~~~~~~~~~~~~~~~~~
| dev_pm_opp_set_clkname
drivers/opp/core.c:2185:16: warning: returning 'int' from a function with return type 'struct opp_table *' makes pointer from integer without a cast [-Wint-conversion]
2185 | return dev_pm_opp_set_clknames(dev, &name, 1);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/opp/core.c: In function 'dev_pm_opp_put_clkname':
drivers/opp/core.c:2195:16: error: implicit declaration of function 'dev_pm_opp_put_clknames'; did you mean 'dev_pm_opp_put_clkname'? [-Werror=implicit-function-declaration]
2195 | return dev_pm_opp_put_clknames(opp_table);
| ^~~~~~~~~~~~~~~~~~~~~~~
| dev_pm_opp_put_clkname
drivers/opp/core.c:2195:16: error: 'return' with a value, in function returning void [-Werror=return-type]
2195 | return dev_pm_opp_put_clknames(opp_table);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/opp/core.c:2193:6: note: declared here
2193 | void dev_pm_opp_put_clkname(struct opp_table *opp_table)
| ^~~~~~~~~~~~~~~~~~~~~~
drivers/opp/core.c: At top level:
drivers/opp/core.c:2204:19: warning: no previous prototype for 'dev_pm_opp_set_clknames' [-Wmissing-prototypes]
2204 | struct opp_table *dev_pm_opp_set_clknames(struct device *dev,
| ^~~~~~~~~~~~~~~~~~~~~~~
drivers/opp/core.c:2204:19: error: conflicting types for 'dev_pm_opp_set_clknames'; have 'struct opp_table *(struct device *, const char * const*, unsigned int)'
drivers/opp/core.c:2185:16: note: previous implicit declaration of 'dev_pm_opp_set_clknames' with type 'int()'
2185 | return dev_pm_opp_set_clknames(dev, &name, 1);
| ^~~~~~~~~~~~~~~~~~~~~~~
In file included from include/linux/kernel.h:29,
from include/linux/clk.h:13,
from drivers/opp/core.c:13:
drivers/opp/core.c: In function 'dev_pm_opp_set_clknames':
>> drivers/opp/core.c:2252:34: error: 'np' undeclared (first use in this function); did you mean 'up'?
2252 | of_node_full_name(np), count, opp_table->clk_count);
| ^~
include/linux/printk.h:418:33: note: in definition of macro 'printk_index_wrap'
418 | _p_func(_fmt, ##__VA_ARGS__); \
| ^~~~~~~~~~~
include/linux/printk.h:489:9: note: in expansion of macro 'printk'
489 | printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~
drivers/opp/core.c:2251:9: note: in expansion of macro 'pr_err'
2251 | pr_err("AAA %s:%d - read %s - %d clocks (count %d)\n", __func__, __LINE__,
| ^~~~~~
drivers/opp/core.c:2252:34: note: each undeclared identifier is reported only once for each function it appears in
2252 | of_node_full_name(np), count, opp_table->clk_count);
| ^~
include/linux/printk.h:418:33: note: in definition of macro 'printk_index_wrap'
418 | _p_func(_fmt, ##__VA_ARGS__); \
| ^~~~~~~~~~~
include/linux/printk.h:489:9: note: in expansion of macro 'printk'
489 | printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~
drivers/opp/core.c:2251:9: note: in expansion of macro 'pr_err'
2251 | pr_err("AAA %s:%d - read %s - %d clocks (count %d)\n", __func__, __LINE__,
| ^~~~~~
drivers/opp/core.c: At top level:
drivers/opp/core.c:2271:6: warning: no previous prototype for 'dev_pm_opp_put_clknames' [-Wmissing-prototypes]
2271 | void dev_pm_opp_put_clknames(struct opp_table *opp_table)
| ^~~~~~~~~~~~~~~~~~~~~~~
drivers/opp/core.c:2271:6: warning: conflicting types for 'dev_pm_opp_put_clknames'; have 'void(struct opp_table *)'
drivers/opp/core.c:2195:16: note: previous implicit declaration of 'dev_pm_opp_put_clknames' with type 'void(struct opp_table *)'
2195 | return dev_pm_opp_put_clknames(opp_table);
| ^~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +2252 drivers/opp/core.c
2203
2204 struct opp_table *dev_pm_opp_set_clknames(struct device *dev,
2205 const char * const names[],
2206 unsigned int count)
2207 {
2208 struct opp_table *opp_table;
2209 struct clk *clk;
2210 int ret, i;
2211
2212 opp_table = _add_opp_table(dev, false, OPP_TABLE_VERSION_2);
2213 if (IS_ERR(opp_table))
2214 return opp_table;
2215
2216 /* This should be called before OPPs are initialized */
2217 if (WARN_ON(!list_empty(&opp_table->opp_list))) {
2218 ret = -EBUSY;
2219 goto err;
2220 }
2221
2222 /* clk shouldn't be initialized at this point */
2223 if (WARN_ON(opp_table->clks)) {
2224 ret = -EBUSY;
2225 goto err;
2226 }
2227
2228 if (!names) {
2229
2230 }
2231 opp_table->clks = kmalloc_array(count, sizeof(*opp_table->clks),
2232 GFP_KERNEL);
2233 if (!opp_table->clks) {
2234 ret = -ENOMEM;
2235 goto err;
2236 }
2237
2238 for (i = 0; i < count; i++) {
2239 clk = clk_get(dev, names[i]);
2240 if (IS_ERR(clk)) {
2241 ret = dev_err_probe(dev, PTR_ERR(clk),
2242 "%s: Couldn't find clock %s\n",
2243 __func__, names[i]);
2244 goto free_clks;
2245 }
2246 pr_err("AAA getting clock %s=%px\n", names[i], clk);
2247
2248 opp_table->clks[i] = clk;
2249 }
2250
2251 pr_err("AAA %s:%d - read %s - %d clocks (count %d)\n", __func__, __LINE__,
> 2252 of_node_full_name(np), count, opp_table->clk_count);
2253 opp_table->clk_count = count;
2254
2255 return opp_table;
2256
2257 free_clks:
2258 while (i != 0)
2259 clk_put(opp_table->clks[--i]);
2260
2261 kfree(opp_table->clks);
2262 opp_table->clks = NULL;
2263 opp_table->clk_count = -1;
2264 err:
2265 dev_pm_opp_put_opp_table(opp_table);
2266
2267 return ERR_PTR(ret);
2268 }
2269 EXPORT_SYMBOL_GPL(dev_pm_opp_set_clknames);
2270
--
0-DAY CI Kernel Test Service
https://01.org/lkp