Re: [PATCH v2 04/14] dt-bindings: arm: mediatek: document WED binding for MT7622
From: Arnd Bergmann
Date: Wed Apr 06 2022 - 07:41:42 EST
On Wed, Apr 6, 2022 at 10:18 AM Felix Fietkau <nbd@xxxxxxxx> wrote:
> On 06.04.22 10:09, Krzysztof Kozlowski wrote:
> > On 05/04/2022 21:57, Felix Fietkau wrote:
> >> From: Lorenzo Bianconi <lorenzo@xxxxxxxxxx>
> >> Document the binding for the Wireless Ethernet Dispatch core on the MT7622
> >> SoC, which is used for Ethernet->WLAN offloading
> >> Add related info in mediatek-net bindings.
> >> Signed-off-by: Lorenzo Bianconi <lorenzo@xxxxxxxxxx>
> >> Signed-off-by: Felix Fietkau <nbd@xxxxxxxx>
> > Thank you for your patch. There is something to discuss/improve.
> >> ---
> >> .../arm/mediatek/mediatek,mt7622-wed.yaml | 50 +++++++++++++++++++
> >> .../devicetree/bindings/net/mediatek-net.txt | 2 +
> >> 2 files changed, 52 insertions(+)
> >> create mode 100644 Documentation/devicetree/bindings/arm/mediatek/mediatek,mt7622-wed.yaml
> > Don't store drivers in arm directory. See:
> > https://lore.kernel.org/linux-devicetree/YkJa1oLSEP8R4U6y@xxxxxxxxxxxxxxxxxx/
> > Isn't this a network offload engine? If yes, then probably it should be
> > in "net/".
> It's not a network offload engine by itself. It's a SoC component that
> connects to the offload engine and controls a MTK PCIe WLAN device,
> intercepting interrupts and DMA rings in order to be able to inject
> packets coming in from the offload engine.
> Do you think it still belongs in net, or maybe in soc instead?
I think it belongs into drivers/net/. Presumably this has some kind of
user interface to configure which packets are forwarded? I would not
want to maintain that in a SoC driver as this clearly needs to communicate
with both of the normal network devices in some form.