Re: [PATCH 5.16 0000/1017] 5.16.19-rc1 review

[Anders Roxell]

On Wed, 6 Apr 2022 at 01:03, Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx> wrote:
>
> On 4/5/22 1:15 AM, Greg Kroah-Hartman wrote:
> > This is the start of the stable review cycle for the 5.16.19 release.
> > There are 1017 patches in this series, all will be posted as a response
> > to this one.  If anyone has any issues with these being applied, please
> > let me know.
> >
> > Responses should be made by Thu, 07 Apr 2022 07:01:33 +0000.
> > Anything received after that time might be too late.
> >
> > The whole patch series can be found in one patch at:
> >       https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.16.19-rc1.gz
> > or in the git tree and branch at:
> >       git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.16.y
> > and the diffstat can be found below.
> >
> > thanks,
> >
> > greg k-h
> >
>
> Build failed on my system. The following is the problem commit. There
> are no changes to the config between 5.16.18 and this build.
>
> Ranjani Sridharan <ranjani.sridharan@xxxxxxxxxxxxxxx>
>      ASoC: SOF: Intel: hda: Remove link assignment limitation

I saw the same build error, after applying the following patches it
builds fine again.
198fa4bcf6a1 ("ASoC: SOF: intel: add snd_sof_dsp_check_sdw_irq ops")
81ed6770ba67 ("ASoC: SOF: Intel: hda: expose get_chip_info()")

Cheers,
Anders

>
>    CC [M]  sound/soc/sof/intel/hda-dai.o
> sound/soc/sof/intel/hda-dai.c: In function ‘hda_link_stream_assign’:
> sound/soc/sof/intel/hda-dai.c:86:24: error: implicit declaration of function ‘get_chip_info’; did you mean ‘get_group_info’? [-Werror=implicit-function-declaration]
>     86 |                 chip = get_chip_info(sdev->pdata);
>        |                        ^~~~~~~~~~~~~
>        |                        get_group_info
> sound/soc/sof/intel/hda-dai.c:86:22: error: assignment to ‘const struct sof_intel_dsp_desc *’ from ‘int’ makes pointer from integer without a cast [-Werror=int-conversion]
>     86 |                 chip = get_chip_info(sdev->pdata);
>        |                      ^
> sound/soc/sof/intel/hda-dai.c:94:35: error: ‘const struct sof_intel_dsp_desc’ has no member named ‘quirks’
>     94 |                         if (!(chip->quirks & SOF_INTEL_PROCEN_FMT_QUIRK)) {
>        |                                   ^~
> sound/soc/sof/intel/hda-dai.c:94:46: error: ‘SOF_INTEL_PROCEN_FMT_QUIRK’ undeclared (first use in this function)
>     94 |                         if (!(chip->quirks & SOF_INTEL_PROCEN_FMT_QUIRK)) {
>        |                                              ^~~~~~~~~~~~~~~~~~~~~~~~~~
> sound/soc/sof/intel/hda-dai.c:94:46: note: each undeclared identifier is reported only once for each function it appears in
> cc1: all warnings being treated as errors
> make[4]: *** [scripts/Makefile.build:287: sound/soc/sof/intel/hda-dai.o] Error 1
> make[3]: *** [scripts/Makefile.build:549: sound/soc/sof/intel] Error 2
> make[2]: *** [scripts/Makefile.build:549: sound/soc/sof] Error 2
> make[1]: *** [scripts/Makefile.build:549: sound/soc] Error 2
> make: *** [Makefile:1846: sound] Error 2
>
> thanks,
> -- Shuah

-- 
Linaro LKFT
https://lkft.linaro.org