Re: [PATCH] qed: remove an unneed NULL check on list iterator
From: Jakub Kicinski
Date: Wed Apr 06 2022 - 09:52:34 EST
On Tue, 5 Apr 2022 08:22:56 +0800 Xiaomeng Tong wrote:
> struct pci_dev *qed_validate_ndev(struct net_device *ndev)
> {
> - struct pci_dev *pdev = NULL;
> + struct pci_dev *pdev;
> struct net_device *upper;
Please keep the longest-to-shortest ordering of variable declaration
lines.