Re: [PATCH net] net: phy: marvell-88x2222: set proper phydev->port

From: Ivan Bornyakov
Date: Wed Apr 06 2022 - 09:57:10 EST

On Tue, Apr 05, 2022 at 06:14:11PM +0200, Andrew Lunn wrote:
> On Tue, Apr 05, 2022 at 06:03:05PM +0300, Ivan Bornyakov wrote:
> > phydev->port was not set and always reported as PORT_TP.
> > Set phydev->port according to inserted SFP module.
> This is definitely something for Russell to review.
> But i'm wondering if this is the correct place to do this? What about
> at803x and marvell10g?

I guess them need this too, but I only have HW with Marvell 88X2222.

> It seems like this should be done once in the
> core somewhere, not in each driver.
> Andrew

Apart from sfp_parse_port(), sfp_parse_support() and
sfp_select_interface() are also present in all
sfp_upstream_ops->module_insert PHY callbacks.