Re: [PATCH 0/5] imx: support noc settings with power domain

From: Lucas Stach
Date: Wed Apr 06 2022 - 10:08:46 EST

Hi Peng,

Am Mittwoch, dem 06.04.2022 um 16:23 +0800 schrieb Peng Fan (OSS):
> From: Peng Fan <>
> i.MX8MP has a design that NoC(Not main NoC) is distributed in multiple
> blocks, such as vpumix, hsiomix and etc. The access to NoC requires
> power domain on and blk ctrl settings configured.
> So the design here is for mixes that not have blk-ctrl, configure
> the NoC in gpcv2 driver, for mixes that have blk-ctrl, configure
> the NoC in blk-ctrl drivers.
> This v1 patchset not apply on Shawn's tree, I picked up Lucas's HSIO
> and Laurent's mediablk patches, then worked out this patchset:
> Note: This interconnect related functions not added. This patchset
> is only to replace the function did in NXP downstream:

As a general comment I think this is implemented the wrong way around.

Neither GPC, nor the blk-ctrl should poke into the NoC registers
directly. The NoC driver should attach itself to the power domain via a
notifier (same as the blk-ctrl does with the GPC domains) and should do
the necessary NoC configuration when the power domain is powered up.

> Peng Fan (5):
> dt-bindings: interconnect: imx8m: Add bindings for imx8mp noc
> arm64: dts: imx8mp: add noc node
> soc: imx: gpcv2: support i.MX8MP NoC settings
> soc: imx: imx8m-blk-ctrl: support i.MX8MP media blk ctrl noc settings
> soc: imx: imx8mp-blk-ctrl: introduce HSIO blk ctrl noc settings
> .../bindings/interconnect/fsl,imx8m-noc.yaml | 6 +
> arch/arm64/boot/dts/freescale/imx8mp.dtsi | 7 ++
> drivers/soc/imx/gpcv2.c | 56 ++++++++-
> drivers/soc/imx/imx8m-blk-ctrl.c | 109 ++++++++++++++++++
> drivers/soc/imx/imx8mp-blk-ctrl.c | 74 ++++++++++++
> 5 files changed, 251 insertions(+), 1 deletion(-)