Re: [PATCH V9 4/6] regulator: Add a regulator driver for the PM8008 PMIC

[Satya Priya Kakitapalli (Temp)]

On 4/6/2022 12:39 AM, Stephen Boyd wrote:
> Quoting Satya Priya (2022-04-05 06:50:31)
> > diff --git a/drivers/regulator/qcom-pm8008-regulator.c b/drivers/regulator/qcom-pm8008-regulator.c
> > new file mode 100644
> > index 0000000..0f6d5cb
> > --- /dev/null
> > +++ b/drivers/regulator/qcom-pm8008-regulator.c
> > @@ -0,0 +1,205 @@
> [...]
> > +
> > +static struct platform_driver pm8008_regulator_driver = {
> Why isn't this an i2c driver?


The parent mfd driver(qcom-pm8008.c) uses i2c to communicate, this is 
the child to that and hence we don't use i2c driver here.


> > +       .driver = {
> > +               .name           = "qcom,pm8008-regulators",
> > +       },
> > +       .probe  = pm8008_regulator_probe,
> > +};