RE: [PATCH 1/5] dt-bindings: interconnect: imx8m: Add bindings for imx8mp noc

[Peng Fan]

> Subject: Re: [PATCH 1/5] dt-bindings: interconnect: imx8m: Add bindings for
> imx8mp noc
> 
> Hi Peng,
> 
> Thank you for the patch.
> 
> On Wed, Apr 06, 2022 at 04:23:26PM +0800, Peng Fan (OSS) wrote:
> > From: Peng Fan <peng.fan@xxxxxxx>
> >
> > i.MX8MP features same NoC/NIC as i.MX8MM/N/Q, and use two
> compatible
> > strings.
> >
> > Signed-off-by: Peng Fan <peng.fan@xxxxxxx>
> > ---
> >  .../devicetree/bindings/interconnect/fsl,imx8m-noc.yaml     | 6 ++++++
> >  1 file changed, 6 insertions(+)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/interconnect/fsl,imx8m-noc.yaml
> > b/Documentation/devicetree/bindings/interconnect/fsl,imx8m-noc.yaml
> > index b8204ed22dd5..0923cd28d6c6 100644
> > ---
> > a/Documentation/devicetree/bindings/interconnect/fsl,imx8m-noc.yaml
> > +++
> b/Documentation/devicetree/bindings/interconnect/fsl,imx8m-noc.yam
> > +++ l
> > @@ -26,16 +26,22 @@ properties:
> >      oneOf:
> >        - items:
> >            - enum:
> > +              - fsl,imx8mp-nic
> >                - fsl,imx8mn-nic
> >                - fsl,imx8mm-nic
> >                - fsl,imx8mq-nic
> 
> Alphabetical order would be nice here, maybe you could sort those entries
> while at it ?

Sure.

> 
> >            - const: fsl,imx8m-nic
> 
> Why do we need both -nic and -noc versions of the compatible string btw ?
> The imx-bus driver matches on

There is NoC and PL301 NIC in i.MX8M*.

> 
> 	{ .compatible = "fsl,imx8mq-noc", .data = "imx8mq-interconnect", },
> 	{ .compatible = "fsl,imx8mm-noc", .data = "imx8mm-interconnect", },
> 	{ .compatible = "fsl,imx8mn-noc", .data = "imx8mn-interconnect", },
> 	{ .compatible = "fsl,imx8m-noc", },
> 	{ .compatible = "fsl,imx8m-nic", },
> 
> >        - items:
> >            - enum:
> > +              - fsl,imx8mp-noc
> >                - fsl,imx8mn-noc
> >                - fsl,imx8mm-noc
> >                - fsl,imx8mq-noc
> 
> Same here.
> 
> >            - const: fsl,imx8m-noc
> > +      - items:
> > +          - const: fsl,imx8mp-noc
> > +          - const: fsl,imx8m-noc
> > +          - const: syscon
> 
> Do we want to support both
> 
> 	compatible = "fsl,imx8mp-noc", "fsl,imx8m-noc";
> 
> and
> 
> 	compatible = "fsl,imx8mp-noc", "fsl,imx8m-noc", "syscon";
> 
> or we can pick one of the two (the latter one in that case I suppose) ?

Latter one should be ok.

Thanks
Peng.

> 
> >        - const: fsl,imx8m-nic
> >
> >    reg:
> 
> --
> Regards,
> 
> Laurent Pinchart