Re: sof_es8336 build failure [was: [PATCH 5.17 0000/1126] 5.17.2-rc1 review]

From: Greg Kroah-Hartman
Date: Wed Apr 06 2022 - 11:27:21 EST


On Wed, Apr 06, 2022 at 09:37:59AM +0200, Jiri Slaby wrote:
> Cc some folks and change subject
>
> On 06. 04. 22, 9:29, Jiri Slaby wrote:
> > On 05. 04. 22, 9:12, Greg Kroah-Hartman wrote:
> > > This is the start of the stable review cycle for the 5.17.2 release.
> > > There are 1126 patches in this series, all will be posted as a response
> > > to this one.  If anyone has any issues with these being applied, please
> > > let me know.
> > ...
> > > Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx>
> > >      ASoC: Intel: sof_es8336: use NHLT information to set dmic and SSP
> >
> > Fails to build w/ suse x86_64 default config [1] (and x86_32 too):
> > > sound/soc/intel/boards/sof_es8336.c: In function ‘sof_es8336_probe’:
> > > sound/soc/intel/boards/sof_es8336.c:482:32: error: ‘struct
> > snd_soc_acpi_mach_params’ has no member named ‘i2s_link_mask’; did you
> > mean ‘link_mask’?
> > >   482 |         if (!mach->mach_params.i2s_link_mask) {
> > >       |                                ^~~~~~~~~~~~~
> > >       |                                link_mask
> > > sound/soc/intel/boards/sof_es8336.c:494:39: error: ‘struct
> > snd_soc_acpi_mach_params’ has no member named ‘i2s_link_mask’; did you
> > mean ‘link_mask’?
> > >   494 |                 if (mach->mach_params.i2s_link_mask & BIT(2))
> > >       |                                       ^~~~~~~~~~~~~
> > >       |                                       link_mask
> > > sound/soc/intel/boards/sof_es8336.c:496:44: error: ‘struct
> > snd_soc_acpi_mach_params’ has no member named ‘i2s_link_mask’; did you
> > mean ‘link_mask’?
> > >   496 |                 else if (mach->mach_params.i2s_link_mask &
> > BIT(1))
> > >       |                                            ^~~~~~~~~~~~~
> > >       |                                            link_mask
> > > sound/soc/intel/boards/sof_es8336.c:498:45: error: ‘struct
> > snd_soc_acpi_mach_params’ has no member named ‘i2s_link_mask’; did you
> > mean ‘link_mask’?
> > >   498 |                 else  if (mach->mach_params.i2s_link_mask &
> > BIT(0))
> > >       |                                             ^~~~~~~~~~~~~
> > >       |                                             link_mask
> >
> > So 679aa83a0fb70dcbf9e97c is missing -- but likely more is needed.
> >
> > [1] https://raw.githubusercontent.com/SUSE/kernel-source/stable/config/x86_64/default
> >
> >

Offending commit now dropped, thanks!

greg k-h