Re: [PATCH 5.10 000/599] 5.10.110-rc1 review

[Steven Rostedt]

On Wed, 6 Apr 2022 10:26:15 +0200
Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:

> Wait, no, I did catch this!  And I sent you a "FAILED" email about it, 4
> of them:
> 	https://lore.kernel.org/r/164905985821176@xxxxxxxxx
> 	https://lore.kernel.org/r/16490598521299@xxxxxxxxx
> 	https://lore.kernel.org/r/1649059845215213@xxxxxxxxx
> 	https://lore.kernel.org/r/16490598398133@xxxxxxxxx
> as the commit applied, but broke the build:

Yes, I know, that's how I knew it was an issue ;-)

> 
> But I didn't drop the offending commit, I should have done that.

Correct.

Oh, so I guess it got in because it applied, but broke the build. Thus,
your scripts catch when a Fixes does not apply, but doesn't handle the
"broken build / boot" case?

> 
> I'll go and drop the offending commit here, if you could submit both of
> them as working backports to stable@vger if/when you want them queued up
> there, that would be great.

The patch that got backported only fixes an issue with new events (hence
why I did not mark it for stable). If those events are not backported,
there's no reason to backport this one.

-- Steve