Re: [PATCH v2 0/4] rpmb subsystem, uapi and virtio-rpmb driver

From: Bart Van Assche
Date: Wed Apr 06 2022 - 17:24:06 EST


On 4/6/22 11:12, Bean Huo wrote:
It is from the ufs-utils.

So, do you vote to add the UFS RPMB driver based on this new framework
to resolve this conflict?

Are any applications using the RPMB code from ufs-utils? It seems to me that the ufs-utils code doe not handle SCSI unit attentions correctly. If a POWER ON unit attention is received as reply to a SECURITY PROTOCOL OUT transaction, the write counter should be reread instead of retrying the SECURITY PROTOCOL OUT command with the same write counter.

Regarding adding a UFS RPMB driver: that seems useful to me since multiple applications make use of the UFS RPMB functionality. My understanding is that currently storageproxyd multiplexes UFS RPMB accesses in Android.

Thanks,

Bart.