Re: [PATCH] scsi: megaraid_sas: remove unnecessary memset

[Sumit Saxena]

On Thu, Apr 7, 2022 at 12:55 PM Wan Jiabing <wanjiabing@xxxxxxxx> wrote:
>
> instance->cmd_list is allocated by kcalloc(). The memory is set to zero.
> It is unnecessary to call memset again.
>
> Signed-off-by: Wan Jiabing <wanjiabing@xxxxxxxx>
Thank you.
Acked-by: Sumit Saxena <sumit.saxena@xxxxxxxxxxxx>
> ---
>  drivers/scsi/megaraid/megaraid_sas_base.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c
> index 8bf72dbc33b7..33f3226023f3 100644
> --- a/drivers/scsi/megaraid/megaraid_sas_base.c
> +++ b/drivers/scsi/megaraid/megaraid_sas_base.c
> @@ -4466,8 +4466,6 @@ int megasas_alloc_cmds(struct megasas_instance *instance)
>                 return -ENOMEM;
>         }
>
> -       memset(instance->cmd_list, 0, sizeof(struct megasas_cmd *) *max_cmd);
> -
>         for (i = 0; i < max_cmd; i++) {
>                 instance->cmd_list[i] = kmalloc(sizeof(struct megasas_cmd),
>                                                 GFP_KERNEL);
> --
> 2.35.1
>

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature