Re: [PATCH v5] platform: x86: Add ChromeOS ACPI device driver

[Enric Balletbo Serra]

Missatge de Muhammad Usama Anjum <usama.anjum@xxxxxxxxxxxxx> del dia
dj., 7 d’abr. 2022 a les 9:36:
>
> On 4/7/22 12:15 PM, Greg Kroah-Hartman wrote:
> > On Thu, Apr 07, 2022 at 12:09:01PM +0500, Enric Balletbo i Serra wrote:
> >> --- /dev/null
> >> +++ b/drivers/platform/x86/chromeos_acpi.c
> >> @@ -0,0 +1,515 @@
> >> +// SPDX-License-Identifier: GPL-2.0-only
> >> +/*
> >> + * ChromeOS specific ACPI extensions
> >> + *
> >> + * Copyright 2011 Google, Inc.
> >> + * Copyright 2020 Google LLC
> >
> > You haven't touched this file in 2 years?
> This file has been changed. I'll discuss and update this. I'll also
> correct this patch's From and authorship. It got messed up.
>

Hi Muhammad,

I was about to reply about the patch's From ;-) when I noticed there
was an email from me that I didn't send. Also, the email address
should bounce as it does not exist anymore which is a bit annoying.

Thanks to work on this, before sending another version, apart from not
messing up the patch's From you should also need to look at the commit
notes, is basically a copy of my latest patch and is outdated, you
should explain what you did new and not copy what I did in the past,
so that also needs a rewrite. I suppose you already looked at the
the latest version which is at, it is a good practice to point to the
latest version so people can look at what was discussed before.

  * https://lore.kernel.org/lkml/20200610224305.GC248110@dtor-ws/t/

In the discussion there are some comments to address, please make sure
to address all of them, or explain why not, and give as much context
as possible because follow discussions that happened 2 years ago.
Sometimes it is difficult to follow.

Best regards,
  Enric

> --
> Muhammad Usama Anjum