Re: [PATCH v2] staging: media: ipu3: Fix AWB x_start position when rightmost stripe is used

From: Dan Carpenter
Date: Thu Apr 07 2022 - 09:27:06 EST


On Thu, Apr 07, 2022 at 09:17:38PM +0800, Kate Hsuan wrote:
> Hi Dan,
>
> On Thu, Apr 7, 2022 at 7:52 PM Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
> >
> > On Thu, Apr 07, 2022 at 06:57:24PM +0800, Kate Hsuan wrote:
> > > A not calibrated x_start setting would result in an incorrect AWB location
> > > configuration on a sensor when only the rightmost stripe is used. x_start
> > > should be calibrated by subtracting the stripe offset to set the coordinate
> > > to the correct position on the second stripe.
> > >
>
> >
> > I wish the commit description said more about what the bug looks like to
> > the user. This is the front facing camera, right? Is part of the video
> > blank or what's the deal?
>
> This is IPU3 image processor. I tried to fix the configuration issues
> on stripe 1 coordinate settings.
>

So in terms of users, if you configure it in a certain way then it
crashes? What happens in terms of what the ordinary user sees?

regards,
dan carpenter