Re: [PATCH -next] ftrace: Fix build warning

[Steven Rostedt]

On Thu, 7 Apr 2022 15:46:12 +0800
YueHaibing <yuehaibing@xxxxxxxxxx> wrote:

> If CONFIG_SYSCTL and CONFIG_DYNAMIC_FTRACE is n, build warns:
> 
> kernel/trace/ftrace.c:7912:13: error: ‘is_permanent_ops_registered’ defined but not used [-Werror=unused-function]
>  static bool is_permanent_ops_registered(void)
>              ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> kernel/trace/ftrace.c:89:12: error: ‘last_ftrace_enabled’ defined but not used [-Werror=unused-variable]
>  static int last_ftrace_enabled;
>             ^~~~~~~~~~~~~~~~~~~
> 
> Move is_permanent_ops_registered() to ifdef block and mark last_ftrace_enabled as
> __maybe_unused to fix this.
> 
> Fixes: 7cde53da38a3 ("ftrace: move sysctl_ftrace_enabled to ftrace.c")
> Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx>
> ---
>  kernel/trace/ftrace.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Acked-by: Steven Rostedt (Google) <rostedt@xxxxxxxxxxx>

-- Steve