Re: [PATCH] ASoC: rt5682: Add jack kcontrol

From: Akihiko Odaki
Date: Thu Apr 07 2022 - 11:46:40 EST

On 2022/04/08 0:09, Mark Brown wrote:
On Thu, Apr 07, 2022 at 11:13:16PM +0900, Akihiko Odaki wrote:

Create a jack kcontrol manually as rt5682 does not use DAPM pins
for jack and will not have kcontrols for them.

Why not use DAPM for the jack? Note that normally the jack is part of
the machine driver not the CODEC - there's no way the CODEC can know how
it's been wired in on any given system.

It seems it is an unsual case where the codec knows the source of the jack. RT5682 has interrupts and registers for the jack; see e.g. rt5682_button_detect in sound/soc/codecs/rt5682.c for details.

Akihiko Odaki