[PATCH bpf-next v2] selftests/bpf: Fix return value checks in perf_event_stackmap.c
From: Yuntao Wang
Date: Fri Apr 08 2022 - 00:15:54 EST
The bpf_get_stackid() function may also return 0 on success.
Correct checks from 'val > 0' to 'val >= 0' to ensure that they cover all
possible success return values.
Signed-off-by: Yuntao Wang <ytcoode@xxxxxxxxx>
---
v1 -> v2: update commit message
tools/testing/selftests/bpf/progs/perf_event_stackmap.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/testing/selftests/bpf/progs/perf_event_stackmap.c b/tools/testing/selftests/bpf/progs/perf_event_stackmap.c
index b3fcb5274ee0..f793280a3238 100644
--- a/tools/testing/selftests/bpf/progs/perf_event_stackmap.c
+++ b/tools/testing/selftests/bpf/progs/perf_event_stackmap.c
@@ -35,10 +35,10 @@ int oncpu(void *ctx)
long val;
val = bpf_get_stackid(ctx, &stackmap, 0);
- if (val > 0)
+ if (val >= 0)
stackid_kernel = 2;
val = bpf_get_stackid(ctx, &stackmap, BPF_F_USER_STACK);
- if (val > 0)
+ if (val >= 0)
stackid_user = 2;
trace = bpf_map_lookup_elem(&stackdata_map, &key);
--
2.35.0.rc2