Re: [PATCH v2] staging: wfx: use container_of() to get vif

From: Stefano Brivio
Date: Fri Apr 08 2022 - 01:44:56 EST


Greg,

On Fri, 8 Apr 2022 06:45:52 +0200
Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:

> On Thu, Apr 07, 2022 at 11:23:49PM -0400, Jaehee Park wrote:
> >
> > [...]
> >
> > @@ -61,7 +63,6 @@ struct wfx_dev {
> >
> > struct wfx_vif {
> > struct wfx_dev *wdev;
> > - struct ieee80211_vif *vif;
>
> You need to test this on real hardware. For an outreachy-first-task,
> this is not a good one at all.

We discussed about this on the outreachy list, and I suggested, as
Jaehee also mentioned, that maybe somebody (Jérôme?) with the hardware
could give it a try.

It looks a bit difficult but it also looks almost correctly done now. :)

> Also this code is no longer in drivers/staging/ Please work on the
> netdev mailing list as I can not take these changes anymore.

Yeah, missed by a couple of days...

Jaehee, the list is actually linux-wireless for this one:
https://wireless.wiki.kernel.org/en/developers/mailinglists

And the tree (my bad for mentioning net-next earlier) is actually
wireless-next:
https://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless-next.git/

--
Stefano