Re: [PATCH v1 1/7] md/raid5: Cleanup setup_conf() error returns

From: Christoph Hellwig
Date: Fri Apr 08 2022 - 02:06:09 EST


On Thu, Apr 07, 2022 at 10:57:07AM -0600, Logan Gunthorpe wrote:
> Be more careful about the error returns. Most errors in this function
> are actually ENOMEM, but it forcibly returns EIO if conf has been
> allocated.
>
> Instead return ret and ensure it is set appropriately before each goto
> abort.
>
> Signed-off-by: Logan Gunthorpe <logang@xxxxxxxxxxxx>

Looks good:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>