Re: [PATCH v7] mm/hwpoison: fix race between hugetlb free/demotion and memory_failure_hugetlb()

From: Miaohe Lin
Date: Fri Apr 08 2022 - 02:28:36 EST


On 2022/4/8 13:07, HORIGUCHI NAOYA(堀口 直也) wrote:
>
>>>> Without this patch, page refcnt is not decremented if MF_COUNT_INCREASED is set in flags
>>>> when PageHWPoison is already set. So I think this patch also fixes that issue. Thanks!
>>>
>>> Good point, I even didn't notice that. And the issue still seems to exist
>>> for normal page's cases. Maybe encountering "already hwpoisoned" case from
>>> madvise_inject_error() is rare but could happen when the first call failed
>>> to contain the error (which is still accessible from the calling process).
>>
>> Oh, I missed normal page's issue. :) Will you fix this issue kindly or am I supposed
>> to fix it?
>
> I'll try it too, ;)
>

That's very kind of you. ;)
Thanks.

> Thanks,
> Naoya Horiguchi
>