Re: [PATCH] staging: octeon-usb: remove unnecessary parentheses

[Greg Kroah-Hartman]

On Fri, Apr 08, 2022 at 09:30:37AM +0200, Artur Bujdoso wrote:
> Adhere to Linux kernel coding style.
> 
> Reported by checkpatch:
> 
> CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses
> 
> Signed-off-by: Artur Bujdoso <artur.bujdoso@xxxxxxxxx>
> ---
>  drivers/staging/octeon-usb/octeon-hcd.c | 62 ++++++++++++-------------
>  1 file changed, 31 insertions(+), 31 deletions(-)
> 
> diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb/octeon-hcd.c
> index a1cd81d4a114..32bcd6c582f5 100644
> --- a/drivers/staging/octeon-usb/octeon-hcd.c
> +++ b/drivers/staging/octeon-usb/octeon-hcd.c
> @@ -1101,9 +1101,9 @@ static struct cvmx_usb_pipe *cvmx_usb_open_pipe(struct octeon_hcd *usb,
>  	pipe = kzalloc(sizeof(*pipe), GFP_ATOMIC);
>  	if (!pipe)
>  		return NULL;
> -	if ((device_speed == CVMX_USB_SPEED_HIGH) &&
> -	    (transfer_dir == CVMX_USB_DIRECTION_OUT) &&
> -	    (transfer_type == CVMX_USB_TRANSFER_BULK))
> +	if (device_speed == CVMX_USB_SPEED_HIGH &&
> +	    transfer_dir == CVMX_USB_DIRECTION_OUT &&
> +	    transfer_type == CVMX_USB_TRANSFER_BULK)
>  		pipe->flags |= CVMX_USB_PIPE_FLAGS_NEED_PING;

Nah, the original is fine, no need to change this.

Unless, do you have this hardware?  If so, getting this out of staging
would be nice to have happen one day.

thanks,

greg k-h