Re: [PATCH v2 05/14] dt-bindings: arm: mediatek: document the pcie mirror node on MT7622

[Felix Fietkau]

On 07.04.22 19:19, Rob Herring wrote:
> On Tue, Apr 05, 2022 at 09:57:46PM +0200, Felix Fietkau wrote:
> > From: Lorenzo Bianconi <lorenzo@xxxxxxxxxx>
> >
> > This patch adds the pcie mirror document bindings for MT7622 SoC.
> > The feature is used for intercepting PCIe MMIO access for the WED core
> > Add related info in mediatek-net bindings.
> >
> > Signed-off-by: Lorenzo Bianconi <lorenzo@xxxxxxxxxx>
> > Signed-off-by: Felix Fietkau <nbd@xxxxxxxx>
> > ---
> >  .../mediatek/mediatek,mt7622-pcie-mirror.yaml | 42 +++++++++++++++++++
> >  .../devicetree/bindings/net/mediatek-net.txt  |  2 +
> >  2 files changed, 44 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/arm/mediatek/mediatek,mt7622-pcie-mirror.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt7622-pcie-mirror.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt7622-pcie-mirror.yaml
> > new file mode 100644
> > index 000000000000..9fbeb626ab23
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt7622-pcie-mirror.yaml
> > @@ -0,0 +1,42 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: "http://devicetree.org/schemas/arm/mediatek/mediatek,mt7622-pcie-mirror.yaml#";
> > +$schema: "http://devicetree.org/meta-schemas/core.yaml#";
> > +
> > +title: MediaTek PCIE Mirror Controller for MT7622
> > +
> > +maintainers:
> > +  - Lorenzo Bianconi <lorenzo@xxxxxxxxxx>
> > +  - Felix Fietkau <nbd@xxxxxxxx>
> > +
> > +description:
> > +  The mediatek PCIE mirror provides a configuration interface for PCIE
> > +  controller on MT7622 soc.
> > +
> > +properties:
> > +  compatible:
> > +    items:
> > +      - enum:
> > +          - mediatek,mt7622-pcie-mirror
> > +      - const: syscon
>
> This doesn't sound like a syscon to me. Are there multiple clients or
> functions in this block? A 'syscon' property is not the only way to
> create a regmap if that's what you need.
It's used only by the WED code in the ethernet driver, but there are 
multiple WED instances and only a single pcie-mirror block containing 
configuration for them.

- Felix