Re: [PATCH v2 2/3] tty: Add lookahead param to receive_buf

From: Andy Shevchenko
Date: Fri Apr 08 2022 - 08:02:43 EST


On Fri, Apr 08, 2022 at 02:39:53PM +0300, Ilpo Järvinen wrote:
> After lookahead for XON/XOFF characters is added by the next
> patch, the receive side needs to ensure the flow-control
> actions are not retaken later on when those same characters
> get read by TTY.
>
> Thus, pass lookahead count to receive_buf and skip
> flow-control character actions if already taken for the
> character in question. Lookahead count will become live after
> the next patch.

...

> + if (c == STOP_CHAR(tty)) {
> + if (!lookahead_done)

But now it can be as below

if (c == STOP_CHAR(tty) && !lookahead_done)

> + stop_tty(tty);
> + } else if ((c == START_CHAR(tty) && !lookahead_done) ||
> (tty->flow.stopped && !tty->flow.tco_stopped && I_IXANY(tty) &&
> c != INTR_CHAR(tty) && c != QUIT_CHAR(tty) &&
> c != SUSP_CHAR(tty))) {


--
With Best Regards,
Andy Shevchenko