Re: [PATCH v2] staging: rtl8723bs: remove unnecessary `if`

[Dan Carpenter]

On Fri, Apr 08, 2022 at 06:59:11AM -0700, Yihao Han wrote:
> remove a unnecesarry if in `sd_recv_rxfifo`
> 
> Suggested-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> Signed-off-by: Yihao Han <hanyihao@xxxxxxxx>
> ---
  ^^^
Under this cut off line then you need to say what changed since version
1.  Something like: "v2: more extensive cleanup.  v3: edit commit message".

I do want you to edit the commit message because I don't think it really
describes the patch very well.  How I would write this commit message is
this:

    [PATCH v3] staging: rtl8723bs: tidy up error handling

    The check for if rtw_skb_alloc() fails is done twice and is written
    in a confusing way.  Move the "if (!recvbuf->pskb)" right after
    the allocation.  The "if (recvbuf->pskb)" check can now be deleted
    and the code pulled in one tab.

To me this explains the problem and the solution.

regards,
dan carpenter