Re: [PATCH] drm/amdgpu: Fix NULL pointer dereference

[Christian König]

Am 08.04.22 um 15:21 schrieb Grigory Vasilyev:
> Simon Ser and Bas Nieuwenhuizen, do you understand that you are
> proposing to make the code less safe in the future? In the future,
> someone might rewrite the code and we'll get an error.

Which is perfectly fine.

See error handling is to handle userspace or hardware errors and *not* 
coding errors.

Testing all pointers for NULL without any reason is not defensive, but 
rather the exactly opposite since it helps hiding real bugs.

Regards,
Christian.

> пт, 8 апр. 2022 г. в 14:48, Simon Ser <contact@xxxxxxxxxxx>:
> > On Friday, April 8th, 2022 at 13:28, Bas Nieuwenhuizen <bas@xxxxxxxxxxxxxxxxxxx> wrote:
> >
> > > On Fri, Apr 8, 2022 at 12:01 PM Simon Ser contact@xxxxxxxxxxx wrote:
> > >
> > > > Is amdgpu_display_get_fb_info ever called with NULL tiling_flags/tmz_surface?
> > > > If not, there's no point in adding NULL checks.
> > > It isn't called with NULL anywhere, the NULL checks that already exist
> > > seem redundant.
> > Grigory, would be be willing to submit a v2 which removes the unnecessary
> > NULL checks?