Re: [PATCH v8 00/11] Fix BUG_ON in vfio_iommu_group_notifier()
From: Bjorn Helgaas
Date: Fri Apr 08 2022 - 11:59:28 EST
On Fri, Apr 08, 2022 at 05:37:16PM +0200, Joerg Roedel wrote:
> On Fri, Apr 08, 2022 at 11:17:47AM -0300, Jason Gunthorpe wrote:
> > You might consider using a linear tree instead of the topic branches,
> > topics are tricky and I'm not sure it helps a small subsystem so much.
> > Conflicts between topics are a PITA for everyone, and it makes
> > handling conflicts with rc much harder than it needs to be.
>
> I like the concept of a branch per driver, because with that I can just
> exclude that branch from my next-merge when there are issues with it.
> Conflicts between branches happen too, but they are quite manageable
> when the branches have the same base.
FWIW, I use the same topic branch approach for PCI. I like the
ability to squash in fixes or drop things without having to clutter
the history with trivial commits and reverts. I haven't found
conflicts to be a problem.
Bjorn