Re: [PATCH 1/1] of: overlay: of_overlay_apply() kfree() errors

From: Frank Rowand
Date: Fri Apr 08 2022 - 13:41:04 EST


On 4/8/22 12:34, Rob Herring wrote:
> On Fri, Apr 8, 2022 at 12:21 PM <frowand.list@xxxxxxxxx> wrote:
>>
>> From: Frank Rowand <frank.rowand@xxxxxxxx>
>
> The subject needs a verb.
>
>>
>> Fix various kfree() issues related to of_overlay_apply().
>> - Double kfree() of fdt and tree when init_overlay_changeset()
>> returns an error.
>> - free_overlay_changeset() free of the root of the unflattened
>> overlay (variable tree) instead of the memory that contains
>> the unflattened overlay.
>> - Move similar kfree()s from multiple error locations to a
>> common error path (err_free_tree_unlocked:).
>
> What about my question/suggestion on the original patch from Slawomir?
>

I lost track of your email while investigating the problem. I'll go
back and look at your suggestion and question.

-Frank