Re: [PATCHv1] kbuild: support W=e to make build abort in case of warning

[Randy Dunlap]

On 4/8/22 13:29, Nick Desaulniers wrote:
> On Fri, Apr 8, 2022 at 4:06 AM Masahiro Yamada <masahiroy@xxxxxxxxxx> wrote:
>>
>> On Fri, Apr 8, 2022 at 5:46 PM Yann Droneaud <ydroneaud@xxxxxxxxxx> wrote:
>>>
>>> When developing new code/feature, CONFIG_WERROR is most
>>> often turned off, especially for people using make W=12 to
>>> get more warnings.
>>>
>>> In such case, turning on -Werror temporarily would require
>>> switching on CONFIG_WERROR in the configuration, building,
>>> then switching off CONFIG_WERROR.
>>>
>>> For this use case, this patch introduces a new 'e' modifier
>>> to W= as a short hand for KCFLAGS+=-Werror" so that -Werror
>>> got added to the kernel (built-in) and modules' CFLAGS.
>>>
>>> Signed-off-by: Yann Droneaud <ydroneaud@xxxxxxxxxx>
>>> ---
>>>  Makefile                   |  1 +
>>>  scripts/Makefile.extrawarn | 13 +++++++++++--
>>>  2 files changed, 12 insertions(+), 2 deletions(-)
>>>
>>> Changes since v0[0]:
>>>
>>>  - rebase on top of commit 64a91907c896 ("kbuild: refactor scripts/Makefile.extrawarn")
>>>  - document use case after commit 3fe617ccafd6 ("Enable '-Werror' by default for all kernel builds")
>>>
>>> [0] https://lore.kernel.org/all/1422803720-14723-1-git-send-email-ydroneaud@xxxxxxxxxx/
>>
>>
>> I remembered the previous submission, I liked it, but I had lost it.
>>
>> It seems already 7 years ago, (before I became the Kbuild maintainer).
>> Thanks for coming back to this.
>>
>>
>> I like this, but I will wait some time for review comments.
> 
> Dunno, this seems pretty simple:
> 
> $ ./scripts/config -e WERROR
> $ make ... W=12

Yeah, that's about what I was thinking too..

-- 
~Randy