Re: [PATCH 4/6] arm64: dts: qcom: sm8250: move sound node out of soc

[Bjorn Andersson]

On Mon 28 Mar 12:14 CDT 2022, Vinod Koul wrote:

> On 28-03-22, 17:14, Krzysztof Kozlowski wrote:
> > On 28/03/2022 16:30, Vinod Koul wrote:
> > > The soc node expects all the nodes to have unit addresses. The sound
> > > node does not have that which causes warnings:
> > > 
> > > arch/arm64/boot/dts/qcom/sm8250.dtsi:2806.16-2807.5:
> > > Warning (simple_bus_reg): /soc@0/sound: missing or empty reg/ranges property
> > > 
> > > Move sound node out of soc to fix this
> > > 
> > > Signed-off-by: Vinod Koul <vkoul@xxxxxxxxxx>
> > > ---
> > >  arch/arm64/boot/dts/qcom/sm8250.dtsi | 6 +++---
> > >  1 file changed, 3 insertions(+), 3 deletions(-)
> > > 
> > 
> > I don't know the SM8250, but usually the sound node (e.g. containing
> > audio-codec) is not part of SoC. I propose to remove it entirely from
> > DTSI and define in same place in each DTS. It makes more sense logically
> > in such case - one clearly see which board defines the sounds, which
> > does not.
> 
> Most of our boards have sound, should we duplicate it in all the
> boards..? Bjorn..?
> 

But is the sndcard platform or device specific? E.g. all the SDM845
boards seems to use either qcom,sdm845-sndcard or qcom,db845c-sndcard.

Are there room for some common properties in this node?


Otherwise it seems reasonable to skip it in the platform dtsi.

Regards,
Bjorn