Re: [PATCH RESEND net-next v5 2/4] net: skb: rename SKB_DROP_REASON_PTYPE_ABSENT
From: David Ahern
Date: Fri Apr 08 2022 - 23:50:36 EST
On 4/7/22 12:20 AM, menglong8.dong@xxxxxxxxx wrote:
> From: Menglong Dong <imagedong@xxxxxxxxxxx>
>
> As David Ahern suggested, the reasons for skb drops should be more
> general and not be code based.
>
> Therefore, rename SKB_DROP_REASON_PTYPE_ABSENT to
> SKB_DROP_REASON_UNHANDLED_PROTO, which is used for the cases of no
> L3 protocol handler, no L4 protocol handler, version extensions, etc.
>
> From previous discussion, now we have the aim to make these reasons
> more abstract and users based, avoiding code based.
>
> Signed-off-by: Menglong Dong <imagedong@xxxxxxxxxxx>
> ---
> include/linux/skbuff.h | 8 +++-----
> include/trace/events/skb.h | 2 +-
> net/core/dev.c | 8 +++-----
> 3 files changed, 7 insertions(+), 11 deletions(-)
>
Reviewed-by: David Ahern <dsahern@xxxxxxxxxx>