Re: [PATCH 15/18] MIPS: DTS: CI20: fix fixed regulators as reported by dtbscheck

[Krzysztof Kozlowski]

On 08/04/2022 20:37, H. Nikolaus Schaller wrote:
> arch/mips/boot/dts/ingenic/ci20.dtb: /: fixedregulator@0: 'anyOf' conditional failed, one must be fixed:
> 	'reg' is a required property
> 	'ranges' is a required property
> 	From schema: python/site-packages/dtschema/schemas/root-node.yaml
> arch/mips/boot/dts/ingenic/ci20.dtb: /: fixedregulator@1: 'anyOf' conditional failed, one must be fixed:
> 	'reg' is a required property
> 	'ranges' is a required property
> 	From schema: python/site-packages/dtschema/schemas/root-node.yaml
> arch/mips/boot/dts/ingenic/ci20.dtb: /: fixedregulator@2: 'anyOf' conditional failed, one must be fixed:
> 	'reg' is a required property
> 	'ranges' is a required property
> 	From schema: python/site-packages/dtschema/schemas/root-node.yaml
> 
> Signed-off-by: H. Nikolaus Schaller <hns@xxxxxxxxxxxxx>
> ---
>  arch/mips/boot/dts/ingenic/ci20.dts | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/mips/boot/dts/ingenic/ci20.dts b/arch/mips/boot/dts/ingenic/ci20.dts
> index cb5257d32b55e..c045c4f75895e 100644
> --- a/arch/mips/boot/dts/ingenic/ci20.dts
> +++ b/arch/mips/boot/dts/ingenic/ci20.dts
> @@ -69,7 +69,7 @@ led3 {
>  		};
>  	};
>  
> -	eth0_power: fixedregulator@0 {
> +	eth0_power: eth3v3 {

No, Devicetree spec requires generic node name, so "regulator-0" is
appropriate. See also examples of device tree node names in the spec.
"eth3v3" is a specific one, not generic.


Best regards,
Krzysztof