Re: [PATCH v6 2/2] mmc: Add mmc driver for Sunplus SP7021

[Krzysztof Kozlowski]

On 09/04/2022 13:11, Tony Huang 黃懷厚 wrote:
> Dear Arnd:
> 
>>
>> All error/warnings (new ones prefixed by >>):
>>
>>    drivers/mmc/host/sunplus-mmc.c: In function 'spmmc_set_bus_timing':
>>>> drivers/mmc/host/sunplus-mmc.c:311:15: warning: variable
>>>> 'timing_name' set but not used [-Wunused-but-set-variable]
>>      311 |         char *timing_name;
>>          |               ^~~~~~~~~~~
>>    drivers/mmc/host/sunplus-mmc.c: At top level:
>>>> drivers/mmc/host/sunplus-mmc.c:798:13: warning: no previous prototype
>>>> for 'spmmc_irq' [-Wmissing-prototypes]
>>      798 | irqreturn_t spmmc_irq(int irq, void *dev_id)
>>          |             ^~~~~~~~~
>>>> drivers/mmc/host/sunplus-mmc.c:894:5: warning: no previous prototype
>>>> for 'spmmc_get_cd' [-Wmissing-prototypes]
>>      894 | int spmmc_get_cd(struct mmc_host *mmc)
>>          |     ^~~~~~~~~~~~
>>    drivers/mmc/host/sunplus-mmc.c: In function 'spmmc_drv_probe':
>>>> drivers/mmc/host/sunplus-mmc.c:1021:22: warning: variable 'mode' set
>>>> but not used [-Wunused-but-set-variable]
>>     1021 |         unsigned int mode;
>>          |                      ^~~~
>>    drivers/mmc/host/sunplus-mmc.c: At top level:
>>>> drivers/mmc/host/sunplus-mmc.c:1170:9: error: implicit declaration of
>>>> function 'SYSTEM_SLEEP_PM_OPS'; did you mean
>>>> 'SET_SYSTEM_SLEEP_PM_OPS'? [-Werror=implicit-function-declaration]
>>     1170 |         SYSTEM_SLEEP_PM_OPS(spmmc_pm_suspend,
>> spmmc_pm_resume)
>>          |         ^~~~~~~~~~~~~~~~~~~
>>          |         SET_SYSTEM_SLEEP_PM_OPS
> 
> I follow your sugguest in v5. 						
> "It's better to use SYSTEM_SLEEP_PM_OPS/RUNTIME_PM_OPS instead of the SET_ version"						
> But kernel test robot shows error.						

Which you need to fix. Kernel test robot gave you tools needed to
reproduce all these errors, so go ahead and fix them. :)

Best regards,
Krzysztof